Bug 128303 – REGRESSION (r160879): Replacing 'navigator' doesn't work, breaks Cordova library

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Radek Pietruszewski]

Hello,

A library I'm using (Cordova) does this:

>    var CordovaNavigator = function() {};
>    CordovaNavigator.prototype = window.navigator;
>    window.navigator = new CordovaNavigator();

I'm not sure why it does that (the comment above says: "Replace navigator before any modules are required(), to ensure it happens as soon as possible. We replace it so that properties that can't be clobbered can instead be overridden.", but I'm not sure what that means), but it's always worked fine. It works on Safari 6 and 7, on iOS 6, 7, 7.1b4 and on Android, but on the latest nightlies (r163498 is the newest I checked) it breaks. All method calls and property accesses throw TypeError and typing `navigator` in Inspector's console returns vague "Error".

I'm not a JS expert, but AFAICT it appears to be a WebKit bug.

I attached a test case.

[Radek Pietruszewski]

Created attachment 223323 [details]
test case

[Alexey Proskuryakov]

This regressed in <http://trac.webkit.org/r160879>.

[Radek Pietruszewski]

This shipped in iOS 8 beta and breaks a lot of apps.

Hoping for a fix in seed 2!

[Radek Pietruszewski]

Fixed (sometime between iOS 8 beta 1 and 2, apparently).

[Oliver Hunt]

(In reply to comment #4)
> Fixed (sometime between iOS 8 beta 1 and 2, apparently).
Yeah, there's another similar bug that i should have duped this to - please file bugs on any other weirdness you encounter :D