Bug 128286 - run-webkit-tests should have a --no-timeout option
Summary: run-webkit-tests should have a --no-timeout option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 17:17 PST by Joseph Pecoraro
Modified: 2014-03-31 11:15 PDT (History)
5 users (show)

See Also:

Attachments
Adding --no-timeout option (3.79 KB, patch)
2014-03-31 03:20 PDT, Berta József 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-02-05 17:17:41 PST 
It is very difficult to debug a test in DumpRenderTree if there is a timeout. Also, --time-out-ms doesn't seem to be respected.
Comment 1 Alexey Proskuryakov 2014-02-06 09:36:33 PST 
FWIW, --time-out-ms always works for me. It gets tricker with WebKit2, because there is an additional option to pass to disable a different timeout, I don't remember which one offhand.
Comment 2 Berta József 2014-03-31 03:20:34 PDT 
Created attachment 228164 [details]
Adding --no-timeout option
Comment 3 Joseph Pecoraro 2014-03-31 10:45:53 PDT 
Comment on attachment 228164 [details]
Adding --no-timeout option

r=me, nice!
Comment 4 WebKit Commit Bot 2014-03-31 11:15:54 PDT 
Comment on attachment 228164 [details]
Adding --no-timeout option

Clearing flags on attachment: 228164

Committed r166515: <http://trac.webkit.org/changeset/166515>
Comment 5 WebKit Commit Bot 2014-03-31 11:15:58 PDT 
All reviewed patches have been landed.  Closing bug.