Bug 128284 - Support encoding and decoding of Regions
Summary: Support encoding and decoding of Regions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 16:54 PST by Simon Fraser (smfr)
Modified: 2014-02-05 20:27 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.03 KB, patch)
2014-02-05 16:57 PST, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-02-05 16:54:33 PST 
Support encoding and decoding of Regions
Comment 1 Simon Fraser (smfr) 2014-02-05 16:57:08 PST 
Created attachment 223281 [details]
Patch
Comment 2 Anders Carlsson 2014-02-05 17:58:45 PST 
Comment on attachment 223281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223281&action=review

> Source/WebCore/platform/graphics/Region.cpp:336
> +    for (Shape::SpanIterator span = spans_begin(), end = spans_end(); span != end && span + 1 != end; ++span) {

auto span

> Source/WebCore/platform/graphics/Region.cpp:343
> +        for (Shape::SegmentIterator segment = segments_begin(span), end = segments_end(span); segment != end && segment + 1 != end; segment += 2) {

auto segment

> Source/WebCore/platform/graphics/Region.h:75
> +        { }

Should be newline:
{
}

> Source/WebCore/platform/graphics/Region.h:79
> +        { }

Newline
{
}
Comment 3 Simon Fraser (smfr) 2014-02-05 20:27:22 PST 
https://trac.webkit.org/r163509