Bug 128277 – WK2: Tap highlight is positioned incorrectly in iframes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

Created attachment 223275 [details]
Test case

Open the attached testcase (iframe-page.html) and tap on the link in the iframe. Note that the tap hightlight is offset.

<rdar://problem/15975993>

[Enrica Casucci]

Created attachment 223277 [details]
Patch

[Benjamin Poulain]

Comment on attachment 223277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review

Thanks!

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328
> +                currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1())));
> +                currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2())));
> +                currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3())));
> +                currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4())));

Can you please file a bug to me to convert this to floating point?

[Simon Fraser (smfr)]

Comment on attachment 223277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328
>> +                currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1())));
>> +                currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2())));
>> +                currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3())));
>> +                currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4())));
> 
> Can you please file a bug to me to convert this to floating point?

It sucks that we all the mapping 4 times (it can be expensive). We should have a way to convert a set of points all at the same time too.

[Enrica Casucci]

(In reply to comment #3)
> (From update of attachment 223277 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review
> 
> >> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328
> >> +                currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1())));
> >> +                currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2())));
> >> +                currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3())));
> >> +                currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4())));
> > 
> > Can you please file a bug to me to convert this to floating point?
> 
> It sucks that we all the mapping 4 times (it can be expensive). We should have a way to convert a set of points all at the same time too.

The upside is that we do this conversion only for tap highlight and only if it is not the main frame.

[Enrica Casucci]

Committed revision 163499.