Bug 12826 - Allow overwriting Product, ProductSub, Vendor and VendorSub js properties
Summary: Allow overwriting Product, ProductSub, Vendor and VendorSub js properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-19 22:00 PST by Krzysztof Kowalczyk
Modified: 2007-02-20 13:27 PST (History)
1 user (show)

See Also:


Attachments
Allow overwriting Product, ProductSub, Vendor and VendorSub js properties (2.04 KB, patch)
2007-02-19 22:01 PST, Krzysztof Kowalczyk
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2007-02-19 22:00:09 PST
Allow over-writting Product, ProductSub, Vendor and VendorSub js properties via #define WEBCORE_NAVIGATOR_*
Comment 1 Krzysztof Kowalczyk 2007-02-19 22:01:03 PST
Created attachment 13266 [details]
Allow overwriting Product, ProductSub, Vendor and VendorSub js properties
Comment 2 Maciej Stachowiak 2007-02-20 00:54:36 PST
Product and ProductSub are defined as they are for compatibility reasons. I am not sure it is wise to change them. It might make sense to make Vendor and VendorSub configurable, but perhaps doing this at runtime as for the user agent string would make more sense.
Comment 3 Darin Adler 2007-02-20 11:22:48 PST
Comment on attachment 13266 [details]
Allow overwriting Product, ProductSub, Vendor and VendorSub js properties

r=me
Comment 4 Krzysztof Kowalczyk 2007-02-20 13:27:27 PST
Landed in r19740