Bug 128257 - IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
Summary: IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 124521
  Show dependency treegraph
 
Reported: 2014-02-05 10:26 PST by Brady Eidson
Modified: 2014-02-05 15:55 PST (History)
7 users (show)

See Also:


Attachments
Patch v1 (20.55 KB, patch)
2014-02-05 15:24 PST, Brady Eidson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-05 10:26:42 PST
IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails

- The schema of the index record table is out of whack
- We mess up storing auto generated keys in indexes
- After the above are fixed, something is preventing us from returning that auto generated id in the result of an index.get()
Comment 1 Brady Eidson 2014-02-05 15:14:03 PST
(In reply to comment #0)
> IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
> ...
> - After the above are fixed, something is preventing us from returning that auto generated id in the result of an index.get()

This was because the IDBGetResult shipped back from the database process did not contain the object store key path when it was needed.
Comment 2 Radar WebKit Bug Importer 2014-02-05 15:21:56 PST
<rdar://problem/15995237>
Comment 3 Brady Eidson 2014-02-05 15:24:16 PST
Created attachment 223271 [details]
Patch v1
Comment 4 WebKit Commit Bot 2014-02-05 15:26:23 PST
Attachment 223271 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:77:  The parameter name "result" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:74:  The parameter name "result" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2014-02-05 15:55:35 PST
http://trac.webkit.org/changeset/163482