Bug 128249 - Add support for MallocScribble to FastMalloc
Summary: Add support for MallocScribble to FastMalloc
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-05 07:48 PST by David Kilzer (:ddkilzer)
Modified: 2022-02-28 03:46 PST (History)
8 users (show)

See Also:

Attachments
Patch v1 (5.81 KB, patch)
2014-02-05 11:37 PST, David Kilzer (:ddkilzer) 		oliver: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-02-05 07:48:43 PST 
We should add support for MallocScribble to FastMalloc.
Comment 1 David Kilzer (:ddkilzer) 2014-02-05 07:49:00 PST 
<rdar://problem/15946481>
Comment 2 David Kilzer (:ddkilzer) 2014-02-05 11:37:30 PST 
Created attachment 223252 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-02-05 11:40:05 PST 
Attachment 223252 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/FastMalloc.cpp:460:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WTF/wtf/FastMalloc.cpp:1273:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Oliver Hunt 2014-02-05 11:48:29 PST 
Comment on attachment 223252 [details]
Patch v1

It would be better to just modify POISON_DEALLOCATION as that will get all deallocations, and already has the correct allocation size
Comment 5 David Kilzer (:ddkilzer) 2016-11-04 13:58:34 PDT 
FastMalloc was replaced by bmalloc.