Bug 128242 - Code cleanup: Remove BUILDING_ON / TARGETING definitions.
Summary: Code cleanup: Remove BUILDING_ON / TARGETING definitions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 03:59 PST by Tamas Gergely
Modified: 2014-02-10 03:20 PST (History)
5 users (show)

See Also:

Attachments
patch (3.39 KB, patch)
2014-02-05 04:02 PST, Tamas Gergely 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2014-02-05 03:59:51 PST 
According to the FIXME, BUILDING_ON_* and TARGETING_* macros can be removed. They have been used nowhere in the code for a while.
Comment 1 Tamas Gergely 2014-02-05 04:02:53 PST 
Created attachment 223226 [details]
patch
Comment 2 Brent Fulgham 2014-02-05 16:27:36 PST 
Comment on attachment 223226 [details]
patch

Seems fine to me! r=me
Comment 3 WebKit Commit Bot 2014-02-10 03:20:39 PST 
Comment on attachment 223226 [details]
patch

Clearing flags on attachment: 223226

Committed r163776: <http://trac.webkit.org/changeset/163776>
Comment 4 WebKit Commit Bot 2014-02-10 03:20:41 PST 
All reviewed patches have been landed.  Closing bug.