Bug 128236 - Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
Summary: Copying failing test paths from build.webkit.org/dashboard popovers also copi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on: 80159
  Show dependency treegraph
Reported: 2014-02-05 00:27 PST by Alexey Proskuryakov
Modified: 2014-02-05 11:59 PST (History)
3 users (show)

See Also:

proposed fix (2.58 KB, patch)
2014-02-05 00:38 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-02-05 00:27:02 PST
Copying multiple paths from test results popover also copies diff/pretty diff/images/stderr/history links text, even though it's non-selectable.

This is a manifestation of bug 80159. It's quite annoying, so I'd like to work around it.

css2.1/20110323/border-conflict-element-001d.htmimagesimage diffhistory
css2.1/20110323/c541-word-sp-001.htmimagesimage diffhistory
css2.1/20110323/floats-001.htmlimagesimage diffhistory
css2.1/20110323/margin-collapse-clear-012.htmimagesimage diffhistory
css2.1/20110323/margin-collapse-clear-013.htmimagesimage diffhistory
Comment 1 Alexey Proskuryakov 2014-02-05 00:38:14 PST
Created attachment 223215 [details]
proposed fix
Comment 2 Timothy Hatcher 2014-02-05 11:11:02 PST
Comment on attachment 223215 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=223215&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:221
> +            var iterator = document.createNodeIterator(

Comment 3 WebKit Commit Bot 2014-02-05 11:59:49 PST
Comment on attachment 223215 [details]
proposed fix

Clearing flags on attachment: 223215

Committed r163464: <http://trac.webkit.org/changeset/163464>
Comment 4 WebKit Commit Bot 2014-02-05 11:59:51 PST
All reviewed patches have been landed.  Closing bug.