Bug 128234 - Make FTL OSR entry something we only try after we've already compiled the function with the FTL and it still got stuck in a loop after that without ever returning like a sensible function oughta have
Summary: Make FTL OSR entry something we only try after we've already compiled the fun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 128039
  Show dependency treegraph
 
Reported: 2014-02-04 21:44 PST by Filip Pizlo
Modified: 2014-02-05 23:32 PST (History)
10 users (show)

See Also:


Attachments
work in progress (11.06 KB, patch)
2014-02-04 21:55 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (11.11 KB, patch)
2014-02-05 22:27 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-04 21:44:29 PST
Patch forthcoming.

This appears to still give us a speed-up on the kinds of things that OSR entry is good for, while also eliminating pointless OSR entry compilations on other things.
Comment 1 Filip Pizlo 2014-02-04 21:55:25 PST
Created attachment 223211 [details]
work in progress

Still needs testing.  The approach still feels shady.
Comment 2 Filip Pizlo 2014-02-05 22:27:01 PST
Created attachment 223309 [details]
the patch
Comment 3 Geoffrey Garen 2014-02-05 22:30:39 PST
Comment on attachment 223309 [details]
the patch

r=me
Comment 4 Filip Pizlo 2014-02-05 23:32:41 PST
Landed in http://trac.webkit.org/changeset/163517