128231 – [ftlopt] GC should notify us if it resets to_this

Bug 128231 - [ftlopt] GC should notify us if it resets to_this

Summary: [ftlopt] GC should notify us if it resets to_this

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Filip Pizlo

URL:
Keywords:

Depends on:
Blocks:	132357
	Show dependency tree / graph

Attachments
work in progress (5.28 KB, patch) 2014-02-04 20:07 PST, Filip Pizlo	no flags	Details \| Formatted Diff \| Diff
the patch (18.80 KB, patch) 2014-06-24 11:24 PDT, Filip Pizlo	ggaren: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Filip Pizlo 2014-02-04 20:06:50 PST

This appears to not be a speed-up, but it seems like a good idea, so I want a bug for the idea.  I will upload my patch.

Comment 1 Filip Pizlo 2014-02-04 20:07:20 PST

Created attachment 223205 [details]
work in progress

Comment 2 Filip Pizlo 2014-06-24 11:21:38 PDT

This used to be a slow-down but now with all of the work on improving support for polymorphic heap accesses, this is now perf-neutral.

Comment 3 Filip Pizlo 2014-06-24 11:24:55 PDT

Created attachment 233722 [details]
the patch

Comment 4 Geoffrey Garen 2014-06-24 11:28:16 PDT

Comment on attachment 233722 [details]
the patch

r=me

Comment 5 Filip Pizlo 2014-06-24 12:51:52 PDT

Landed in http://trac.webkit.org/changeset/170382