Bug 128223 - Declare GlyphBuffers on the heap instead of the stack
Summary: Declare GlyphBuffers on the heap instead of the stack
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-04 16:48 PST by Myles C. Maxfield
Modified: 2014-02-05 11:54 PST (History)
14 users (show)

See Also:

Attachments
Patch (17.15 KB, patch)
2014-02-04 17:12 PST, Myles C. Maxfield 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-02-04 16:48:30 PST 
Declare GlyphBuffers on the heap instead of the stack
Comment 1 Myles C. Maxfield 2014-02-04 16:51:49 PST 
<rdar://problem/15675294>
Comment 2 Myles C. Maxfield 2014-02-04 17:12:45 PST 
Created attachment 223183 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-02-05 11:54:09 PST 
Comment on attachment 223183 [details]
Patch

It's not clear to me that this the correct solution.
Why is GlyphBuffer so big? Can its inline capacities be reduced?
Does this patch slow us down? Should we cache a GlyphBuffer?