Bug 128213 - Remove <iframe seamless> support.
Summary: Remove <iframe seamless> support.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 15:11 PST by Andreas Kling
Modified: 2014-02-04 20:54 PST (History)
28 users (show)

See Also:


Attachments
Patch (208.64 KB, patch)
2014-02-04 16:36 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (1.05 MB, patch)
2014-02-04 17:01 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (1.05 MB, patch)
2014-02-04 17:06 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (1.06 MB, patch)
2014-02-04 17:40 PST, Andreas Kling
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (822.68 KB, application/zip)
2014-02-04 19:13 PST, Build Bot
no flags Details
Patch (1.06 MB, patch)
2014-02-04 20:07 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-02-04 15:11:58 PST
Remove <iframe seamless> support.
Comment 1 Andreas Kling 2014-02-04 15:12:22 PST
Seamless iframes were behind a runtime flag that we never enabled, and the only other engine that implemented them (Blink) recently removed them. Since the feature is very invasive, let's take it out for now.
Comment 2 Andreas Kling 2014-02-04 16:36:00 PST
Created attachment 223180 [details]
Patch
Comment 3 WebKit Commit Bot 2014-02-04 16:38:41 PST
Attachment 223180 [details] did not pass style-queue:


ERROR: ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2014-02-04 17:01:33 PST
Created attachment 223181 [details]
Patch
Comment 5 Andreas Kling 2014-02-04 17:06:56 PST
Created attachment 223182 [details]
Patch
Comment 6 Andreas Kling 2014-02-04 17:40:28 PST
Created attachment 223189 [details]
Patch
Comment 7 Build Bot 2014-02-04 19:13:51 PST
Comment on attachment 223189 [details]
Patch

Attachment 223189 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6745889108393984

New failing tests:
platform/mac/accessibility/seamless-iframe.html
Comment 8 Build Bot 2014-02-04 19:13:57 PST
Created attachment 223197 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Andreas Kling 2014-02-04 20:07:07 PST
Created attachment 223204 [details]
Patch
Comment 10 WebKit Commit Bot 2014-02-04 20:54:37 PST
Comment on attachment 223204 [details]
Patch

Clearing flags on attachment: 223204

Committed r163427: <http://trac.webkit.org/changeset/163427>
Comment 11 WebKit Commit Bot 2014-02-04 20:54:41 PST
All reviewed patches have been landed.  Closing bug.