Bug 128210 - Handling of opaque roots is wrong in EdenCollections
Summary: Handling of opaque roots is wrong in EdenCollections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 14:53 PST by Mark Hahnenberg
Modified: 2014-02-10 11:54 PST (History)
2 users (show)

See Also:

Attachments
patch (187.68 KB, text/plain)
2014-02-04 17:16 PST, BJ Burg 		no flags Details
Patch (13.24 KB, patch)
2014-02-05 18:08 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (13.24 KB, patch)
2014-02-05 18:17 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (2.66 KB, patch)
2014-02-07 12:58 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-02-04 14:53:02 PST 
The set of opaque roots is always cleared during each collection. We should instead persist the set of opaque roots across EdenCollections and only clear it at the beginning of FullCollections.
Comment 1 BJ Burg 2014-02-04 17:16:36 PST 
Created attachment 223184 [details]
patch
Comment 2 WebKit Commit Bot 2014-02-04 17:18:16 PST 
Attachment 223184 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:67:  The parameter name "button" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:95:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:101:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:141:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:538:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:687:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:823:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:833:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:841:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:865:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:886:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:973:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:80:  The parameter name "button" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 13 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2014-02-04 17:18:51 PST 
(In reply to comment #1)
> Created an attachment (id=223184) [details]
> patch

I think this is the wrong bug :-)
Comment 4 BJ Burg 2014-02-04 17:21:12 PST 
Comment on attachment 223184 [details]
patch

Wrong bugzilla bug. :|
Comment 5 Mark Hahnenberg 2014-02-05 18:08:11 PST 
Created attachment 223285 [details]
Patch
Comment 6 Mark Hahnenberg 2014-02-05 18:17:24 PST 
Created attachment 223286 [details]
Patch
Comment 7 WebKit Commit Bot 2014-02-05 19:33:28 PST 
Comment on attachment 223286 [details]
Patch

Clearing flags on attachment: 223286

Committed r163507: <http://trac.webkit.org/changeset/163507>
Comment 8 WebKit Commit Bot 2014-02-05 19:33:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Mark Hahnenberg 2014-02-07 12:03:58 PST 
D'oh! I forgot to check in the tests.
Comment 10 Mark Hahnenberg 2014-02-07 12:58:16 PST 
Created attachment 223486 [details]
Patch
Comment 11 Geoffrey Garen 2014-02-07 13:52:40 PST 
Comment on attachment 223486 [details]
Patch

r=me
Comment 12 WebKit Commit Bot 2014-02-10 11:54:17 PST 
Comment on attachment 223486 [details]
Patch

Clearing flags on attachment: 223486

Committed r163806: <http://trac.webkit.org/changeset/163806>
Comment 13 WebKit Commit Bot 2014-02-10 11:54:19 PST 
All reviewed patches have been landed.  Closing bug.