Bug 128201 - webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie header when there are no cookies
Summary: webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie heade...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 11:50 PST by Alexey Proskuryakov
Modified: 2014-02-04 15:29 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (1.65 KB, patch)
2014-02-04 11:52 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-02-04 11:50:12 PST 
On platforms that use our webKitCookieStorageCopyRequestHeaderFieldsForURL shim, we fail two regression tests:

http/tests/navigation/ping-same-origin.html
http/tests/navigation/ping-cross-origin.html

This is because we send an empty Cookie header. We shouldn't send one when there are no cookies.
Comment 1 Alexey Proskuryakov 2014-02-04 11:52:20 PST 
Created attachment 223150 [details]
proposed fix
Comment 2 Sam Weinig 2014-02-04 14:27:38 PST 
Comment on attachment 223150 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=223150&action=review

> Source/WebKit2/Shared/mac/CookieStorageShim.mm:64
> +    if (cookies.isNull())

I think we usually do if (!cookies)
Comment 3 WebKit Commit Bot 2014-02-04 15:29:06 PST 
Comment on attachment 223150 [details]
proposed fix

Clearing flags on attachment: 223150

Committed r163409: <http://trac.webkit.org/changeset/163409>
Comment 4 WebKit Commit Bot 2014-02-04 15:29:08 PST 
All reviewed patches have been landed.  Closing bug.