Bug 12820 - REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033
Summary: REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Antti Koivisto
URL: http://build.webkit.org/results/post-...
Keywords: LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2007-02-19 16:30 PST by mitz
Modified: 2007-02-21 19:24 PST (History)
2 users (show)

See Also:


Attachments
another attempt to figure out who should paint the caret (1.86 KB, patch)
2007-02-20 07:50 PST, Antti Koivisto
timothy: review-
Details | Formatted Diff | Diff
yet another (14.68 KB, patch)
2007-02-20 17:37 PST, Antti Koivisto
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-02-19 16:30:08 PST
To reproduce, open LayoutTests/editing/pasteboard/4641033.html. Notice that the caret isn't painting when it is positioned right after the <select> element.

This is a regression from r19706 (fix for bug 11974).
Comment 1 Antti Koivisto 2007-02-20 07:50:50 PST
Created attachment 13273 [details]
another attempt to figure out who should paint the caret

Caret should generally be painted by the containing block of the caret node. Only exception is when the caret node is itself a block and the caret is inside it (not after it). This happens with empty editable block elements.
Comment 2 Dave Hyatt 2007-02-20 14:20:35 PST
Comment on attachment 13273 [details]
another attempt to figure out who should paint the caret

r=me
Comment 3 Antti Koivisto 2007-02-20 17:37:56 PST
Created attachment 13284 [details]
yet another

- added method to SelectionController for testing if caret is inside or outside the node based on Justin's comments
- added test case for <div editable><select> case too
Comment 4 Timothy Hatcher 2007-02-21 08:45:12 PST
Comment on attachment 13273 [details]
another attempt to figure out who should paint the caret

Clearing the review, there is a new patch.
Comment 5 Dave Hyatt 2007-02-21 16:43:44 PST
Comment on attachment 13284 [details]
yet another

r=me
Comment 6 Sam Weinig 2007-02-21 19:24:29 PST
Landed in r19785.