Bug 128197 – WK: Cannot select text inside clickable containers.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

Open www.repubblica.it and navigate to a page that has comments at the bottom.
Tap and hold to select text in a comment.

Expected
The text is selected.

Actual
Nothing happens.

<rdar://problem/15970890>

[Enrica Casucci]

Created attachment 223145 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 223145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223145&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:846
> +                info.url = linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkElement->getAttribute(HTMLNames::hrefAttr)));
> +        } else if (element->isLink()) {
>              info.url = element->document().completeURL(stripLeadingAndTrailingHTMLSpaces(element->getAttribute(HTMLNames::hrefAttr)));
> +            elementIsLinkOrImage = true;

Would be slightly nice to factor this so you only call completeURL() once.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:852
> +    }
> +    if (!elementIsLinkOrImage) {

I would prefer a blank line between these two.

[Enrica Casucci]

Thanks for the review.
I've followed your suggestion and factored out CompleteURL.

[Enrica Casucci]

Committed revision 163400.