RESOLVED FIXED 128195
[GTK] Replace DEFINE_STATIC_LOCAL with NeverDestroyed<T> in GTK WK1 and WK2 code 
https://bugs.webkit.org/show_bug.cgi?id=128195
Summary [GTK] Replace DEFINE_STATIC_LOCAL with NeverDestroyed<T> in GTK WK1 and WK2 code
Zan Dobersek
Reported 2014-02-04 10:57:10 PST
[GTK] Replace DEFINE_STATIC_LOCAL with NeverDestroyed<T> in GTK WK1 and WK2 code
Attachments
Patch (9.82 KB, patch)
2014-02-04 10:59 PST, Zan Dobersek 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-02-04 10:59:32 PST
Created attachment 223140 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-04 11:00:48 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2014-02-04 11:02:09 PST
Comment on attachment 223140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223140&action=review > Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h:69 > + friend class NeverDestroyed<PlatformStrategiesGtk>; Why is this necessary? > Source/WebKit2/WebProcess/gtk/WebGtkExtensionManager.h:55 > + friend class NeverDestroyed<WebGtkExtensionManager>; Ditto.
Zan Dobersek
Comment 4 2014-02-04 11:32:31 PST
Comment on attachment 223140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223140&action=review >> Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.h:69 >> + friend class NeverDestroyed<PlatformStrategiesGtk>; > > Why is this necessary? So that NeverDestroyed<PlatformStrategiesGtk> can access the private PlatformStrategiesGtk constructor.
Zan Dobersek
Comment 5 2014-02-05 02:00:35 PST
Landed in r163433. http://trac.webkit.org/changeset/163433
Note You need to log in before you can comment on or make changes to this bug.