Bug 128186 - GC timer should always do a FullCollection
Summary: GC timer should always do a FullCollection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 08:41 PST by Mark Hahnenberg
Modified: 2014-02-04 10:34 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2014-02-04 09:26 PST, Mark Hahnenberg 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-02-04 08:41:03 PST 
Right now the GC timer does whatever type of collection the next collection would have been, which is almost always an EdenCollection. It then thinks that it has done all of the work it was supposed to do and never schedules another GC. Ideally we'd like to have some heuristics for the timer that would schedule both EdenCollections and FullCollections, but the easiest fix for now is to always do FullCollections, since that will at least be a non-regression.
Comment 1 Mark Hahnenberg 2014-02-04 09:26:16 PST 
Created attachment 223125 [details]
Patch
Comment 2 Mark Hahnenberg 2014-02-04 09:51:27 PST 
Committed r163384: <http://trac.webkit.org/changeset/163384>
Comment 3 Geoffrey Garen 2014-02-04 10:34:48 PST 
> Ideally we'd like to have some heuristics for the timer that would schedule both EdenCollections and FullCollections

Yeah -- and the schedule for full collections should be very long, to avoid touching too many pages.