RESOLVED FIXED 128170
[GTK] Add $(feature_defines) when generating InjectedBundle code from IDLs 
https://bugs.webkit.org/show_bug.cgi?id=128170
Summary [GTK] Add $(feature_defines) when generating InjectedBundle code from IDLs
Carlos Garnacho
Reported 2014-02-04 02:42:33 PST
Patch in bug #98931 relies on the ENABLE_TOUCH_EVENTS define being available at the time of generating the code from the EventSenderProxy IDL, but the --defines switch is empty, so those functions are invariably opted out. I'm attaching a patch that adds $(feature_defines) so config defines are available when generating the code.
Attachments
patch, adds $(feature_defines) (1.38 KB, patch)
2014-02-04 02:50 PST, Carlos Garnacho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garnacho
Comment 1 2014-02-04 02:50:47 PST
Created attachment 223090 [details] patch, adds $(feature_defines)
Carlos Garcia Campos
Comment 2 2014-02-04 06:17:03 PST
Comment on attachment 223090 [details] patch, adds $(feature_defines) Good catch! thanks
Carlos Garcia Campos
Comment 3 2014-02-04 06:21:59 PST
Comment on attachment 223090 [details] patch, adds $(feature_defines) hope it's not too late this might be causing issues when generating the api docs
Carlos Garcia Campos
Comment 4 2014-02-04 06:22:26 PST
See http://webkit-queues.appspot.com/results/4927924343930880
Carlos Garcia Campos
Comment 5 2014-02-04 06:24:06 PST
(In reply to comment #4) > See http://webkit-queues.appspot.com/results/4927924343930880 hmm, wait, this is probably the other patch that depends on this one
Carlos Garcia Campos
Comment 6 2014-02-04 06:25:51 PST
This one seems to be failing as well https://webkit-queues.appspot.com/results/5611648777715712
Carlos Garcia Campos
Comment 7 2014-02-04 06:42:44 PST
Comment on attachment 223090 [details] patch, adds $(feature_defines) I think EWS mixed both patches or something, let's try to land this, it shouldn't affect the GObject DOM bindings
WebKit Commit Bot
Comment 8 2014-02-04 06:45:46 PST
Comment on attachment 223090 [details] patch, adds $(feature_defines) Clearing flags on attachment: 223090 Committed r163375: <http://trac.webkit.org/changeset/163375>
WebKit Commit Bot
Comment 9 2014-02-04 06:45:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.