Bug 128168 - Fine tuning the ARM EFL bots
Summary: Fine tuning the ARM EFL bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 01:59 PST by Gabor Rapcsanyi
Modified: 2014-02-05 10:00 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (3.36 KB, patch)
2014-02-04 02:47 PST, Gabor Rapcsanyi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2014-02-04 01:59:41 PST 
Fine tuning the ARM EFL bots
Comment 1 Gabor Rapcsanyi 2014-02-04 02:47:46 PST 
Created attachment 223089 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2014-02-04 03:47:13 PST 
Comment on attachment 223089 [details]
proposed patch

r=me. 

Lucas, could you possibly restart the master after the landing?
Comment 3 WebKit Commit Bot 2014-02-04 03:49:29 PST 
Comment on attachment 223089 [details]
proposed patch

Clearing flags on attachment: 223089

Committed r163372: <http://trac.webkit.org/changeset/163372>
Comment 4 WebKit Commit Bot 2014-02-04 03:49:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Lucas Forschler 2014-02-04 09:37:06 PST 
master restarted.
Comment 6 Csaba Osztrogonác 2014-02-04 12:49:51 PST 
Comment on attachment 223089 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223089&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:139
> +    def evaluateCommand(self, cmd):
> +        if cmd.rc != 0:
> +            return WARNINGS

I think I got what caused the exception. You 
should return with SUCCESS after it, similar 
to other evaluateCommands in master.cfg
Comment 7 Gabor Rapcsanyi 2014-02-05 04:30:27 PST 
(In reply to comment #6)
> (From update of attachment 223089 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223089&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:139
> > +    def evaluateCommand(self, cmd):
> > +        if cmd.rc != 0:
> > +            return WARNINGS
> 
> I think I got what caused the exception. You 
> should return with SUCCESS after it, similar 
> to other evaluateCommands in master.cfg

Yes sure, the fix landed at:
https://trac.webkit.org/r163441
Comment 8 Lucas Forschler 2014-02-05 10:00:53 PST 
I've restarted the webkit build master for you.