WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128168
Fine tuning the ARM EFL bots
https://bugs.webkit.org/show_bug.cgi?id=128168
Summary
Fine tuning the ARM EFL bots
Gabor Rapcsanyi
Reported
2014-02-04 01:59:41 PST
Fine tuning the ARM EFL bots
Attachments
proposed patch
(3.36 KB, patch)
2014-02-04 02:47 PST
,
Gabor Rapcsanyi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1
2014-02-04 02:47:46 PST
Created
attachment 223089
[details]
proposed patch
Csaba Osztrogonác
Comment 2
2014-02-04 03:47:13 PST
Comment on
attachment 223089
[details]
proposed patch r=me. Lucas, could you possibly restart the master after the landing?
WebKit Commit Bot
Comment 3
2014-02-04 03:49:29 PST
Comment on
attachment 223089
[details]
proposed patch Clearing flags on attachment: 223089 Committed
r163372
: <
http://trac.webkit.org/changeset/163372
>
WebKit Commit Bot
Comment 4
2014-02-04 03:49:31 PST
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 5
2014-02-04 09:37:06 PST
master restarted.
Csaba Osztrogonác
Comment 6
2014-02-04 12:49:51 PST
Comment on
attachment 223089
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=223089&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:139 > + def evaluateCommand(self, cmd): > + if cmd.rc != 0: > + return WARNINGS
I think I got what caused the exception. You should return with SUCCESS after it, similar to other evaluateCommands in master.cfg
Gabor Rapcsanyi
Comment 7
2014-02-05 04:30:27 PST
(In reply to
comment #6
)
> (From update of
attachment 223089
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=223089&action=review
> > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:139 > > + def evaluateCommand(self, cmd): > > + if cmd.rc != 0: > > + return WARNINGS > > I think I got what caused the exception. You > should return with SUCCESS after it, similar > to other evaluateCommands in master.cfg
Yes sure, the fix landed at:
https://trac.webkit.org/r163441
Lucas Forschler
Comment 8
2014-02-05 10:00:53 PST
I've restarted the webkit build master for you.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug