Bug 128163 - [GTK] [Stable] Build unittests only when requested
Summary: [GTK] [Stable] Build unittests only when requested
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-03 23:08 PST by Pacho Ramos
Modified: 2017-03-11 11:05 PST (History)
6 users (show)

See Also:

Attachments
webkit-gtk-2.2.4-unittests-build.patch (2.80 KB, patch)
2014-02-03 23:08 PST, Pacho Ramos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos 2014-02-03 23:08:22 PST 
Created attachment 223074 [details]
webkit-gtk-2.2.4-unittests-build.patch

We are applying this patch on Gentoo to build unittests only when going to run tests

Thanks for applying it
Comment 1 Alberto Garcia 2014-02-05 05:41:13 PST 
Hey, thanks for the patch.

The problem is that we're switching to cmake soon so this will be
obsolete in a few weeks.

We run the tests all the time and changing the workflow of the
developers (even if it's such a small change) shortly before the
switch is probably not a good idea.

This would also need changes in the build-webkit script else the build
bots will probably break.
Comment 2 Carlos Garcia Campos 2014-02-05 05:49:43 PST 
We are not going to switch to cmake in the stable branches.
Comment 3 Pacho Ramos 2014-02-05 13:19:02 PST 
Maybe would be interesting to apply it to 2.2.x branch only then (if there will be more releases)
Comment 4 Alberto Garcia 2014-02-06 01:25:34 PST 
I wouldn't change that at this point for the reasons I already said, but I don't have strong arguments against fixing it in the stable branches either.
Comment 5 Gustavo Noronha (kov) 2014-02-11 03:42:49 PST 
Not opposed, but this is only useful for the 2.2.x stable branch right? In 2.4 we have developer mode.