Bug 128157 – IDB: HTML5 Rocks Indexed Database demo fails

• Status: ASSIGNED
• Component: WebKit2

[Brady Eidson]

IDB: HTML5 Rocks Indexed Database demo fails

The demo can be found here - http://www.html5rocks.com/en/tutorials/indexeddb/todo/

TODOs that you save are stored to the database, but they are never retrieved.

This is because the value cursor they create never returns any values.

And that is because we're choosing the wrong SQL statement for the cursor.

In radar as <rdar://problem/15966095>

[Brady Eidson]

Created attachment 223068 [details]
Patch v1

[Brady Eidson]

Of the large number of layout test failures, this fixes a handful!  \o/

[Jon Lee]

Comment on attachment 223068 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=223068&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:112
> +

This is all fine except the statements are not in consistent order. Line 77-78 is open upper key, not closed upper key like in 85-86 and 92-93.

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:164
> +

This looks good here.

It might be slightly better to name the variables "hasLowerKey", "isLowerOpen", "hasUpperKey", "isUpperOpen", even though the current var names are more consistent with the IDB API.

[Jon Lee]

provisional r-!

[Brady Eidson]

Created attachment 223071 [details]
Patch v2

[Brady Eidson]

Nice find, and good suggestion.  New patch uploaded.

[Jon Lee]

Comment on attachment 223071 [details]
Patch v2

Provisional r=me!

[Brady Eidson]

Thanks for the eyes!

[Brady Eidson]

http://trac.webkit.org/changeset/163364 and http://trac.webkit.org/changeset/163365 as a build fix followup

[Csaba Osztrogonác]

Comment on attachment 223068 [details]
Patch v1

Cleared Anders Carlsson's review+ from obsolete attachment 223068 [details] so that this bug does not appear in http://webkit.org/pending-commit.