Bug 128142 - WK2: Selection callout bar does not scroll with the selection
Summary: WK2: Selection callout bar does not scroll with the selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-03 16:40 PST by Enrica Casucci
Modified: 2014-02-04 10:36 PST (History)
0 users

See Also:


Attachments
Patch (5.81 KB, patch)
2014-02-03 17:30 PST, Enrica Casucci
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-02-03 16:40:57 PST
Open a page in Safari on iOS.
Select some text.
The callout bar appears.
Now scroll to a different position on the screen.

Expected
The callout disappears while scrolling and reappears when done.

Actual
The callout bar stays in the original position.

<rdar://problem/15970812>
Comment 1 Enrica Casucci 2014-02-03 17:30:10 PST
Created attachment 223050 [details]
Patch
Comment 2 Benjamin Poulain 2014-02-03 17:59:39 PST
Comment on attachment 223050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223050&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:272
> +    [_contentView willStartZoomOrScroll];
> +}
> +
> +- (void)scrollViewWillBeginDragging:(UIScrollView *)scrollView
> +{
> +    [_contentView willStartZoomOrScroll];

I may have to split those at some point, we'll see.
Comment 3 Enrica Casucci 2014-02-04 10:36:35 PST
Committed revision 163388