Bug 128126 - Deconstructed parameters aren't being placed in the correct scope
Summary: Deconstructed parameters aren't being placed in the correct scope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-03 14:25 PST by Oliver Hunt
Modified: 2014-02-03 14:39 PST (History)
0 users

See Also:

Attachments
Patch (11.62 KB, patch)
2014-02-03 14:29 PST, Oliver Hunt 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-02-03 14:25:40 PST 
Deconstructed parameters aren't being placed in the correct scope
Comment 1 Oliver Hunt 2014-02-03 14:29:15 PST 
Created attachment 223019 [details]
Patch
Comment 2 Antti Koivisto 2014-02-03 14:38:00 PST 
Comment on attachment 223019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223019&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:67
> +    for (size_t i = 0; i < m_deconstructedParameters.size(); i++) {
> +        auto& entry = m_deconstructedParameters[i];

I would use range-for here and elsewhere.
Comment 3 Oliver Hunt 2014-02-03 14:39:32 PST 
Committed r163328: <http://trac.webkit.org/changeset/163328>