Bug 128114 - AX: WebKit should support @headers/@id for complex accessible web tables
Summary: AX: WebKit should support @headers/@id for complex accessible web tables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-03 11:11 PST by chris fleizach
Modified: 2014-02-03 12:30 PST (History)
9 users (show)

See Also:

Attachments
patch (5.82 KB, patch)
2014-02-03 11:13 PST, chris fleizach 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2014-02-03 11:11:09 PST 
AX: WebKit should support @headers/@id for complex accessible web tables

* STEPS TO REPRODUCE
1. Using VO, navigate the tables on http://webaim.org/articles/voiceover/tables

* RESULTS
headers/id attributes are ignored. This radar represents the WebKit portion of the bug.

<rdar://problem/9199163>
Comment 1 chris fleizach 2014-02-03 11:13:42 PST 
Created attachment 223001 [details]
patch
Comment 2 Darin Adler 2014-02-03 11:51:18 PST 
Comment on attachment 223001 [details]
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:158
> +        AccessibilityObject* object = cache->getOrCreate(element);
> +        if (object)
> +            headers.append(object);

I suggest putting this inside the if statement.

    if (AccessibilityObject* object = cache->getOrCreate(element))
        headers.append(object);

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:162
> +    if (headers.size())

Maybe !headers.isEmpty() would be better?
Comment 3 chris fleizach 2014-02-03 11:52:43 PST 
(In reply to comment #2)
> (From update of attachment 223001 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review
> 
> > Source/WebCore/accessibility/AccessibilityTableCell.cpp:158
> > +        AccessibilityObject* object = cache->getOrCreate(element);
> > +        if (object)
> > +            headers.append(object);
> 
> I suggest putting this inside the if statement.
> 
>     if (AccessibilityObject* object = cache->getOrCreate(element))
>         headers.append(object);
> 
> > Source/WebCore/accessibility/AccessibilityTableCell.cpp:162
> > +    if (headers.size())
> 
> Maybe !headers.isEmpty() would be better?

Done. Thanks!
Comment 4 chris fleizach 2014-02-03 12:30:04 PST 
http://trac.webkit.org/changeset/163320