Bug 128114 – AX: WebKit should support @headers/@id for complex accessible web tables

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

AX: WebKit should support @headers/@id for complex accessible web tables

* STEPS TO REPRODUCE
1. Using VO, navigate the tables on http://webaim.org/articles/voiceover/tables

* RESULTS
headers/id attributes are ignored. This radar represents the WebKit portion of the bug.

<rdar://problem/9199163>

[chris fleizach]

Created attachment 223001 [details]
patch

[Darin Adler]

Comment on attachment 223001 [details]
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:158
> +        AccessibilityObject* object = cache->getOrCreate(element);
> +        if (object)
> +            headers.append(object);

I suggest putting this inside the if statement.

    if (AccessibilityObject* object = cache->getOrCreate(element))
        headers.append(object);

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:162
> +    if (headers.size())

Maybe !headers.isEmpty() would be better?

[chris fleizach]

(In reply to comment #2)
> (From update of attachment 223001 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review
> 
> > Source/WebCore/accessibility/AccessibilityTableCell.cpp:158
> > +        AccessibilityObject* object = cache->getOrCreate(element);
> > +        if (object)
> > +            headers.append(object);
> 
> I suggest putting this inside the if statement.
> 
>     if (AccessibilityObject* object = cache->getOrCreate(element))
>         headers.append(object);
> 
> > Source/WebCore/accessibility/AccessibilityTableCell.cpp:162
> > +    if (headers.size())
> 
> Maybe !headers.isEmpty() would be better?

Done. Thanks!

[chris fleizach]

http://trac.webkit.org/changeset/163320