Bug 128102 - [Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized
Summary: [Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
: 128105 (view as bug list)
Depends on:
Reported: 2014-02-03 04:47 PST by Hunseop Jeong
Modified: 2014-02-03 17:02 PST (History)
7 users (show)

See Also:

Patch (1.64 KB, patch)
2014-02-03 05:08 PST, Hunseop Jeong
no flags Details | Formatted Diff | Diff
Patch for landing (1.64 KB, patch)
2014-02-03 15:00 PST, Hunseop Jeong
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2014-02-03 15:23 PST, Hunseop Jeong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2014-02-03 04:47:42 PST
GraphicsContext::m_pixelSnappingFactor is uninitialized.
Comment 1 Hunseop Jeong 2014-02-03 05:08:13 PST
Created attachment 222976 [details]
Comment 2 Ryuan Choi 2014-02-03 07:31:42 PST
Comment on attachment 222976 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=222976&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL/Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized

It is introduced since r163265 but it looks ommitted GraphicsContextCairo.cpp

Nit, [Cairo] Looks enough because it is used by cairo based ports including GTK, EFL.
Comment 3 Zan Dobersek 2014-02-03 08:38:37 PST
*** Bug 128105 has been marked as a duplicate of this bug. ***
Comment 4 zalan 2014-02-03 08:50:14 PST
Looks correct to me. Sorry for the trouble, I didn't see cairo's extra ctor.
Comment 5 Csaba Osztrogonác 2014-02-03 08:52:42 PST
Comment on attachment 222976 [details]

r=me with comment fix mentioned by Ryuan. Please fix it before landing.
Comment 6 Hunseop Jeong 2014-02-03 15:00:48 PST
Created attachment 223026 [details]
Patch for landing
Comment 7 Jinwoo Song 2014-02-03 15:05:40 PST
Comment on attachment 223026 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=223026&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::GraphicsContext::GraphicsContext): Initalized pixelSnappingFactor to 1 and 

Typo: s/Initalized/Initialized.
'Formatted to match the WebKit coding style' should be 'fixed the coding style violation'.
Comment 8 Hunseop Jeong 2014-02-03 15:23:37 PST
Created attachment 223029 [details]
Comment 9 WebKit Commit Bot 2014-02-03 17:02:15 PST
Comment on attachment 223029 [details]

Clearing flags on attachment: 223029

Committed r163348: <http://trac.webkit.org/changeset/163348>
Comment 10 WebKit Commit Bot 2014-02-03 17:02:22 PST
All reviewed patches have been landed.  Closing bug.