Bug 128095 - Fix context save/restore mistake spotted in SVGInlineTextBox::paintTextWithShadows
Summary: Fix context save/restore mistake spotted in SVGInlineTextBox::paintTextWithSh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 20:51 PST by Darin Adler
Modified: 2014-02-02 22:13 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.76 KB, patch)
2014-02-02 20:52 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-02-02 20:51:42 PST
Fix context save/restore mistake spotted in SVGInlineTextBox::paintTextWithShadows
Comment 1 Darin Adler 2014-02-02 20:52:35 PST
Created attachment 222956 [details]
Patch
Comment 2 Darin Adler 2014-02-02 20:53:41 PST
I spotted this obvious minor logic mistake while making some other changes to this function. This is the minimal change to fix it. I have no idea if the error causes actual symptoms, but it seems worth fixing.
Comment 3 Andreas Kling 2014-02-02 21:45:54 PST
Comment on attachment 222956 [details]
Patch

Sure, r=me.
Maybe someday we can RAII our way out of things like this.
Comment 4 WebKit Commit Bot 2014-02-02 22:13:25 PST
Comment on attachment 222956 [details]
Patch

Clearing flags on attachment: 222956

Committed r163286: <http://trac.webkit.org/changeset/163286>
Comment 5 WebKit Commit Bot 2014-02-02 22:13:28 PST
All reviewed patches have been landed.  Closing bug.