Bug 128071 - Subpixel rendering: Floor thickness and length after switching from int to float.
Summary: Subpixel rendering: Floor thickness and length after switching from int to fl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 09:36 PST by zalan
Modified: 2014-02-02 11:01 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-02-02 09:36:13 PST 
This is a temporary solution to fix the assertion on empty line drawing until after bug 128009 is landed.
Comment 1 zalan 2014-02-02 09:40:02 PST 
Committed r163264: <http://trac.webkit.org/changeset/163264>
Comment 2 Darin Adler 2014-02-02 10:57:13 PST 
On a float it should be floorf. Calling floor will convert to a double, then floor, and then convert back to a float.
Comment 3 zalan 2014-02-02 11:01:04 PST 
(In reply to comment #2)
> On a float it should be floorf. Calling floor will convert to a double, then floor, and then convert back to a float.
hmm, how did I miss that! Thanks. I am planning to land the proper fix for this later today.