Bug 128070 - [GTK] Enabling web audio installs Composite.wav twice
Summary: [GTK] Enabling web audio installs Composite.wav twice
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 08:16 PST by Maciej Piechotka
Modified: 2014-09-30 02:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (556 bytes, patch)
2014-02-02 08:16 PST, Maciej Piechotka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Piechotka 2014-02-02 08:16:45 PST 
Created attachment 222925 [details]
Patch

It looks like it's listed twice in install-data-am dependencies:

install-data-am: install-audioDATA install-data-local \
        install-dist_audioDATA install-dist_resourcesDATA \

This causes problems (at least on Gentoo) where install complains that file do already exists

Changing it to:

if ENABLE_WEB_AUDIO
# Installing HRTF database wav files
audiodir = ${datadir}/webkitgtk-@WEBKITGTK_API_VERSION@/resources/audio/
dist_audio_DATA = $(WebCore)/platform/audio/resources/Composite.wav
endif  # END ENABLE_WEB_AUDIO

Should fix the problem.
Comment 1 WebKit Commit Bot 2014-02-02 08:17:47 PST 
Attachment 222925 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Philippe Normand 2014-09-30 02:13:42 PDT 
Sorry I missed this bug :/ We moved to CMake recently, is this issue still present with the new build system? Feel free to reopen this bug if needed.