Bug 128059 – [EFL] REGRESSION(r163234) EFL debug build is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Hunseop Jeong]

EFL debug build is broken after r163234 on EFL.

[Hunseop Jeong]

Created attachment 222902 [details]
Patch

[Ryuan Choi]

Comment on attachment 222902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222902&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Because this is build fix, you can make the patch as "Unreviewed build fix"

> Source/WebCore/ChangeLog:11
> +        Fixed the broken build on EFL after r163234.
> +
> +        * Modules/indexeddb/IDBKeyData.cpp:
> +        (WebCore::IDBKeyData::loggingString): Added the default: case.

I am not sure whether it is EFL specific.

Maybe "Debug build is broken with INDEXED_DATABASE

> Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:279
>      }

Like other statements,

Can we add it out of switch() with "ASSERT_NOT_REACHED();"

[Hunseop Jeong]

Created attachment 222906 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 222906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222906&action=review

You don't need to request review in unreviewed case.

> Source/WebCore/ChangeLog:3
> +        [EFL] REGRESSION(r163234) EFL debug build is broken

Remove [EFL] prefix.

> Source/WebCore/ChangeLog:6
> +        Unriewed. Debug build is broken with INDEXED_DATABASE.

Typo. Unreviewed.

[Hunseop Jeong]

Created attachment 222909 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 222909 [details]
Patch

Clearing flags on attachment: 222909

Committed r163261: <http://trac.webkit.org/changeset/163261>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.