Bug 128057 - JSC profiler's stub info profiling support should work again
Summary: JSC profiler's stub info profiling support should work again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 128039
  Show dependency tree / graph
 
Reported: 2014-02-01 19:11 PST by Filip Pizlo
Modified: 2014-02-01 22:34 PST (History)
10 users (show)

See Also:

Attachments
the patch (7.81 KB, patch)
2014-02-01 19:14 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-01 19:11:06 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-01 19:14:22 PST 
Created attachment 222898 [details]
the patch
Comment 2 WebKit Commit Bot 2014-02-01 19:17:54 PST 
Attachment 222898 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:978:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp:52:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2014-02-01 19:20:05 PST 
(In reply to comment #2)
> Attachment 222898 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:978:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]

Fixed.

> ERROR: Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp:52:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]

Lol, whoa - that's totally wrong.  4 spaces is clearly the only correct choice here.

> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2014-02-01 22:04:57 PST 
Comment on attachment 222898 [details]
the patch

r=me
Comment 5 Filip Pizlo 2014-02-01 22:34:27 PST 
Landed in http://trac.webkit.org/changeset/163259