Bug 128040 - IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly
Summary: IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" cor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency treegraph
 
Reported: 2014-01-31 22:45 PST by Brady Eidson
Modified: 2014-01-31 23:00 PST (History)
0 users

See Also:


Attachments
Patch v1 (2.98 KB, patch)
2014-01-31 22:47 PST, Brady Eidson
jer.noble: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-31 22:45:26 PST
IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly
Comment 1 Brady Eidson 2014-01-31 22:47:31 PST
Created attachment 222873 [details]
Patch v1
Comment 2 Jer Noble 2014-01-31 22:57:55 PST
Comment on attachment 222873 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222873&action=review

r=me with not even a nit, just a feckless comment:

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:213
> +    bool isUnique = m_cursorDirection == IndexedDB::CursorDirection::NextNoDuplicate || m_cursorDirection == IndexedDB::CursorDirection::PrevNoDuplicate;

This is slightly confusing, but I can't come up with a better solution here, so.
Comment 3 Brady Eidson 2014-01-31 23:00:03 PST
http://trac.webkit.org/changeset/163237