Bug 128029 - PlatformEvent::Type should be an enum class
Summary: PlatformEvent::Type should be an enum class
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-31 16:55 PST by BJ Burg
Modified: 2014-03-28 15:49 PDT (History)
8 users (show)

See Also:

Attachments
EWS round one fight (84.10 KB, patch)
2014-02-03 01:24 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
EWS round two fight (85.41 KB, patch)
2014-02-03 10:10 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
round 3 (85.87 KB, patch)
2014-02-03 11:41 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-01-31 16:55:50 PST 
Also, with the enum class scoping it can be moved outside of the PlatformEvent class to keep the same level of qualification.

I have a patch for this, which I'll rebase this weekend.
Comment 1 BJ Burg 2014-02-03 01:24:41 PST 
Created attachment 222971 [details]
EWS round one fight
Comment 2 WebKit Commit Bot 2014-02-03 01:27:15 PST 
Attachment 222971 [details] did not pass style-queue:


ERROR: Source/WebCore/page/DragController.cpp:98:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1645:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:39:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 3 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 BJ Burg 2014-02-03 10:10:56 PST 
Created attachment 222996 [details]
EWS round two fight
Comment 4 WebKit Commit Bot 2014-02-03 10:14:02 PST 
Attachment 222996 [details] did not pass style-queue:


ERROR: Source/WebCore/page/DragController.cpp:98:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1645:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2014-02-03 11:41:36 PST 
Created attachment 223003 [details]
round 3
Comment 6 WebKit Commit Bot 2014-02-03 11:43:49 PST 
Attachment 223003 [details] did not pass style-queue:


ERROR: Source/WebCore/page/DragController.cpp:98:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1645:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2014-02-06 13:02:10 PST 
Patch looks OK, but I actually prefer PlatformEvent::Type::Foo.
Comment 8 BJ Burg 2014-02-06 13:09:21 PST 
(In reply to comment #7)
> Patch looks OK, but I actually prefer PlatformEvent::Type::Foo.

I can switch back if that's the preferred style here. I had originally moved it outside the class so it could be forward declared.