Bug 128022 – Add webView:didFailNavigation:withError: delegate method

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add webView:didFailNavigation:withError: delegate method

[Anders Carlsson]

Created attachment 222857 [details]
Patch

[Darin Adler]

Comment on attachment 222857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222857&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:743
> +        virtual void didFailLoadWithErrorForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, const ResourceError& error, API::Object* userData) override

Won’t we get a warning because we are not using navigationID here?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:487
> +    WebDocumentLoader& documentLoader = static_cast<WebDocumentLoader&>(*m_frame->coreFrame()->loader().documentLoader());

Do we have a checked version of this cast? Should we?

Seems like coreFrame should return a reference, not a pointer.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 222857 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222857&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.cpp:743
> > +        virtual void didFailLoadWithErrorForFrame(WebPageProxy* page, WebFrameProxy* frame, uint64_t navigationID, const ResourceError& error, API::Object* userData) override
> 
> Won’t we get a warning because we are not using navigationID here?

I don't think we enable that warning.

> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:487
> > +    WebDocumentLoader& documentLoader = static_cast<WebDocumentLoader&>(*m_frame->coreFrame()->loader().documentLoader());
> 
> Do we have a checked version of this cast? Should we?

We're sure that all document loaders are created by WebKit so I don't think we do.

> 
> Seems like coreFrame should return a reference, not a pointer.

I think the member variable backing coreFrame can end up being nulled out.

[Anders Carlsson]

Committed r163243: <http://trac.webkit.org/changeset/163243>