Bug 128013 - WebKit2 View Gestures (Swipe): Crashes swiping around a Google Docs spreadsheet
Summary: WebKit2 View Gestures (Swipe): Crashes swiping around a Google Docs spreadsheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-31 13:03 PST by Tim Horton
Modified: 2014-01-31 13:13 PST (History)
3 users (show)

See Also:

Attachments
patch (2.05 KB, patch)
2014-01-31 13:09 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-31 13:03:20 PST 
We should never (currently) start a swipe from a non-begin-phase wheel event. We already check this in handleScrollWheelEvent, but can still get non-begin-phase events in wheelEventWasNotHandled. And, AppKit throws an exception when we try to start a swipe from end-phase events.

<rdar://problem/15959481>
Comment 1 Tim Horton 2014-01-31 13:09:24 PST 
Created attachment 222841 [details]
patch
Comment 2 Tim Horton 2014-01-31 13:09:53 PST 
Comment on attachment 222841 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222841&action=review

> Source/WebKit2/ChangeLog:24
> -        Sideways 'wobble' when scrolling with trackpad on Mavericks
> -        https://bugs.webkit.org/show_bug.cgi?id=127521
> -        -and corresponding-
> +        Sideways 'wobble' when scrolling with trackpad on Mavericks
> +        https://bugs.webkit.org/show_bug.cgi?id=127521
> +        -and corresponding-

I don't know what my editor is doing here.
Comment 3 Tim Horton 2014-01-31 13:13:33 PST 
http://trac.webkit.org/changeset/163192