RESOLVED FIXED 127991
Remove ENABLE(SVG) guards 
https://bugs.webkit.org/show_bug.cgi?id=127991
Summary Remove ENABLE(SVG) guards
Csaba Osztrogonác
Reported 2014-01-31 03:42:25 PST
discussion about it on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2014-January/026144.html I started to prepare a patch for it.
Attachments
WIP patch - not yet complete (300.75 KB, patch)
2014-01-31 07:31 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch for EWS bots (517.26 KB, patch)
2014-02-03 05:54 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch for EWS bots (517.28 KB, patch)
2014-02-03 06:29 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (597.87 KB, patch)
2014-02-03 08:06 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
with Mac buildfix (597.90 KB, patch)
2014-02-03 09:14 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
with style fixes (598.10 KB, patch)
2014-02-03 09:47 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (605.09 KB, patch)
2014-02-04 04:36 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (604.33 KB, patch)
2014-02-04 07:28 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch for landing (603.14 KB, patch)
2014-02-05 02:12 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-01-31 07:31:03 PST
Created attachment 222812 [details] WIP patch - not yet complete
Csaba Osztrogonác
Comment 2 2014-02-03 05:54:28 PST
Created attachment 222979 [details] patch for EWS bots
Csaba Osztrogonác
Comment 3 2014-02-03 06:29:58 PST
Created attachment 222982 [details] patch for EWS bots
WebKit Commit Bot
Comment 4 2014-02-03 06:32:38 PST
Attachment 222982 [details] did not pass style-queue: ERROR: Source/WebCore/html/parser/XSSAuditor.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/FrameLoader.cpp:108: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSSVGElementInstanceCustom.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/loader/cache/CachedImage.cpp:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/xml/parser/XMLDocumentParser.cpp:49: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/history/CachedFrame.cpp:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderLayer.cpp:109: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:66: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.h:67: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DOMImplementation.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DOMImplementation.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FrameView.cpp:69: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FrameView.cpp:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Document.cpp:140: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/StyleResolver.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/StyleResolver.cpp:121: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Frame.cpp:92: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Text.cpp:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/FilterEffectRenderer.cpp:46: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:62: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Element.cpp:73: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/ScriptElement.cpp:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/gtk/webkit/webkitwebframe.cpp:75: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DocumentStyleSheetCollection.cpp:285: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/bindings/js/JSNodeCustom.cpp:70: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/EventHandler.cpp:85: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/CSSFontSelector.cpp:51: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 29 in 160 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 5 2014-02-03 08:06:19 PST
Created attachment 222987 [details] Patch
WebKit Commit Bot
Comment 6 2014-02-03 08:09:30 PST
Attachment 222987 [details] did not pass style-queue: ERROR: Source/WebCore/html/parser/XSSAuditor.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/FrameLoader.cpp:108: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSSVGElementInstanceCustom.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/loader/cache/CachedImage.cpp:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/xml/parser/XMLDocumentParser.cpp:49: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/history/CachedFrame.cpp:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderLayer.cpp:109: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:66: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.h:67: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DOMImplementation.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DOMImplementation.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FrameView.cpp:69: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FrameView.cpp:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Document.cpp:140: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/StyleResolver.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/StyleResolver.cpp:121: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Frame.cpp:92: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Text.cpp:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/FilterEffectRenderer.cpp:46: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:62: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Element.cpp:73: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/ScriptElement.cpp:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/gtk/webkit/webkitwebframe.cpp:75: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DocumentStyleSheetCollection.cpp:285: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/bindings/js/JSNodeCustom.cpp:70: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/EventHandler.cpp:85: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/CSSFontSelector.cpp:51: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 29 in 284 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 7 2014-02-03 09:14:47 PST
Created attachment 222990 [details] with Mac buildfix
WebKit Commit Bot
Comment 8 2014-02-03 09:18:04 PST
Attachment 222990 [details] did not pass style-queue: ERROR: Source/WebCore/html/parser/XSSAuditor.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:42: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/loader/FrameLoader.cpp:108: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSSVGElementInstanceCustom.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/loader/cache/CachedImage.cpp:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/xml/parser/XMLDocumentParser.cpp:49: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/history/CachedFrame.cpp:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderLayer.cpp:109: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderTreeAsText.cpp:66: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.h:67: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DOMImplementation.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DOMImplementation.cpp:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FrameView.cpp:69: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/FrameView.cpp:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Document.cpp:140: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/StyleResolver.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/StyleResolver.cpp:121: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/Frame.cpp:92: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Text.cpp:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/FilterEffectRenderer.cpp:46: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:59: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:62: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/Element.cpp:73: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/ScriptElement.cpp:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/gtk/webkit/webkitwebframe.cpp:75: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/DocumentStyleSheetCollection.cpp:285: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/bindings/js/JSNodeCustom.cpp:70: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/EventHandler.cpp:85: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/css/CSSFontSelector.cpp:51: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 29 in 283 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 9 2014-02-03 09:47:19 PST
Created attachment 222993 [details] with style fixes
Csaba Osztrogonác
Comment 10 2014-02-04 04:36:24 PST
Created attachment 223098 [details] Patch updated to ToT, updated changelogs
Csaba Osztrogonác
Comment 11 2014-02-04 07:28:17 PST
Created attachment 223114 [details] Patch
Sam Weinig
Comment 12 2014-02-04 14:28:24 PST
Comment on attachment 223114 [details] Patch rs=me! Awesome work. I was worrying I was going to have to do it.
Csaba Osztrogonác
Comment 13 2014-02-05 02:12:45 PST
Created attachment 223224 [details] patch for landing
Csaba Osztrogonác
Comment 14 2014-02-05 03:43:30 PST
Landed in http://trac.webkit.org/changeset/163440
Note You need to log in before you can comment on or make changes to this bug.