Bug 127989 - [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
Summary: [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 127987
  Show dependency tree / graph
 
Reported: 2014-01-31 02:47 PST by Javier Fernandez
Modified: 2014-02-19 06:56 PST (History)
12 users (show)

See Also:

Attachments
Patch (174.09 KB, patch)
2014-02-06 14:23 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Modified the ChangeLog as suggested in the last review. (174.05 KB, patch)
2014-02-07 02:14 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch rebased. (314.02 KB, patch)
2014-02-07 05:11 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2014-01-31 02:47:54 PST 
In the latest WD, grid-definition-{columns|rows} were renamed to grid-template-{columns|rows}.
Comment 1 Javier Fernandez 2014-02-06 13:54:06 PST 
This basically involves merging the same fix I did for blink:

    [CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax

    In the latest WD, grid-definition-{columns|rows} were renamed to grid-template-{columns|rows}.
    
    BUG=BUG=337626

    Review URL: https://codereview.chromium.org/146773002
Comment 2 Javier Fernandez 2014-02-06 14:23:37 PST 
Created attachment 223383 [details]
Patch
Comment 3 Sergio Villar Senin 2014-02-07 01:31:27 PST 
Comment on attachment 223383 [details]
Patch

sgtm
Comment 4 Andreas Kling 2014-02-07 01:39:34 PST 
Comment on attachment 223383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223383&action=review

rs=me on updating the property names. Thanks for keeping this stuff up-to-date!

> Source/WebCore/ChangeLog:10
> +        No new tests, no behavior change.

This statement is inconsistent with the actual changes; there is definitely a behavior change.
Comment 5 Javier Fernandez 2014-02-07 02:14:33 PST 
Created attachment 223437 [details]
Modified the ChangeLog as suggested in the last review.
Comment 6 Javier Fernandez 2014-02-07 05:11:29 PST 
Created attachment 223450 [details]
Patch rebased.
Comment 7 Sergio Villar Senin 2014-02-07 09:11:30 PST 
Comment on attachment 223450 [details]
Patch rebased.

Let's get this in!
Comment 8 WebKit Commit Bot 2014-02-07 09:40:56 PST 
Comment on attachment 223450 [details]
Patch rebased.

Clearing flags on attachment: 223450

Committed r163625: <http://trac.webkit.org/changeset/163625>
Comment 9 WebKit Commit Bot 2014-02-07 09:40:59 PST 
All reviewed patches have been landed.  Closing bug.