RESOLVED FIXED 127979
[Cocoa] Add NEFilterSource support to ContentFilterMac 
https://bugs.webkit.org/show_bug.cgi?id=127979
Summary [Cocoa] Add NEFilterSource support to ContentFilterMac
Andy Estes
Reported 2014-01-30 18:28:06 PST
[Cocoa] Add NEFilterSource support to ContentFilterMac
Attachments
[Cocoa] Add NEFilterSource support to ContentFilterMac (9.55 KB, patch)
2014-01-30 18:49 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
[Cocoa] Add NEFilterSource support to ContentFilterMac (9.97 KB, patch)
2014-01-31 13:25 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
[Cocoa] Add NEFilterSource support to ContentFilterMac (9.99 KB, patch)
2014-01-31 13:27 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Buffer incoming data in ContentFilter when using NEFilterSource (6.35 KB, patch)
2014-02-04 18:02 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Buffer incoming data in ContentFilter when using NEFilterSource (6.49 KB, patch)
2014-02-05 00:42 PST, Andy Estes 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-01-30 18:28:31 PST
<rdar://problem/15061531>
Andy Estes
Comment 2 2014-01-30 18:49:59 PST
Created attachment 222781 [details] [Cocoa] Add NEFilterSource support to ContentFilterMac
WebKit Commit Bot
Comment 3 2014-01-30 18:51:54 PST
Attachment 222781 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/ContentFilterMac.mm:62: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/platform/mac/ContentFilterMac.mm:63: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/platform/mac/ContentFilterMac.mm:64: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/platform/mac/ContentFilterMac.mm:65: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/platform/mac/ContentFilterMac.mm:69: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/platform/mac/ContentFilterMac.mm:70: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 4 2014-01-31 13:25:44 PST
Created attachment 222842 [details] [Cocoa] Add NEFilterSource support to ContentFilterMac
Andy Estes
Comment 5 2014-01-31 13:27:04 PST
Created attachment 222843 [details] [Cocoa] Add NEFilterSource support to ContentFilterMac
Andy Estes
Comment 6 2014-01-31 17:36:40 PST
Committed r163226: <http://trac.webkit.org/changeset/163226>
Andy Estes
Comment 7 2014-02-04 18:02:51 PST
Created attachment 223192 [details] Buffer incoming data in ContentFilter when using NEFilterSource
Andy Estes
Comment 8 2014-02-04 18:03:18 PST
Re-opening to post an additional patch.
Andy Estes
Comment 9 2014-02-05 00:42:01 PST
Created attachment 223217 [details] Buffer incoming data in ContentFilter when using NEFilterSource
Andy Estes
Comment 10 2014-02-05 16:16:06 PST
Committed r163486: <http://trac.webkit.org/changeset/163486>
Note You need to log in before you can comment on or make changes to this bug.