Bug 127917 - WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
Summary: WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-30 10:00 PST by David Farler
Modified: 2014-01-30 14:48 PST (History)
3 users (show)

See Also:

Attachments
patch (1.36 KB, patch)
2014-01-30 10:06 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2014-01-30 10:00:18 PST 
After 162986, https://bugs.webkit.org/show_bug.cgi?id=127688, an implementation for rowHeaders and columnHeaders was left out of AccessibilityUIElementIOS. We need stubs or reference a common Mac implementation of these methods.
Comment 1 chris fleizach 2014-01-30 10:01:35 PST 
i'll take care of this now
Comment 2 David Farler 2014-01-30 10:04:58 PST 
Thanks! I've added the Tools subdirectory to the CI builds.
Comment 3 chris fleizach 2014-01-30 10:06:13 PST 
Created attachment 222681 [details]
patch
Comment 4 David Farler 2014-01-30 10:42:31 PST 
Sorry, one more thing - DumpRenderTree also needs implementations.
Comment 5 chris fleizach 2014-01-30 10:57:24 PST 
(In reply to comment #4)
> Sorry, one more thing - DumpRenderTree also needs implementations.

Did DRT fail, because I saw this line was added

#if !PLATFORM(MAC)
void AccessibilityUIElement::uiElementArrayAttributeValue(JSStringRef, Vector<AccessibilityUIElement>&) const { }
void AccessibilityUIElement::columnHeaders(Vector<AccessibilityUIElement>&) const { }
void AccessibilityUIElement::rowHeaders(Vector<AccessibilityUIElement>&) const { }
#endif
Comment 6 David Farler 2014-01-30 10:59:09 PST 
It did but I must be behind that change, I don't have those lines in r163079. If those were added after that, then disregard and I'll update :)
Comment 7 chris fleizach 2014-01-30 14:20:11 PST 
Comment on attachment 222681 [details]
patch

Thanks!
Comment 8 WebKit Commit Bot 2014-01-30 14:48:08 PST 
Comment on attachment 222681 [details]
patch

Clearing flags on attachment: 222681

Committed r163117: <http://trac.webkit.org/changeset/163117>
Comment 9 WebKit Commit Bot 2014-01-30 14:48:10 PST 
All reviewed patches have been landed.  Closing bug.