Bug 127917 – WebKitTestRunner fails to link - missing rowHeaders and columnHeaders

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Farler]

After 162986, https://bugs.webkit.org/show_bug.cgi?id=127688, an implementation for rowHeaders and columnHeaders was left out of AccessibilityUIElementIOS. We need stubs or reference a common Mac implementation of these methods.

[chris fleizach]

i'll take care of this now

[David Farler]

Thanks! I've added the Tools subdirectory to the CI builds.

[chris fleizach]

Created attachment 222681 [details]
patch

[David Farler]

Sorry, one more thing - DumpRenderTree also needs implementations.

[chris fleizach]

(In reply to comment #4)
> Sorry, one more thing - DumpRenderTree also needs implementations.

Did DRT fail, because I saw this line was added

#if !PLATFORM(MAC)
void AccessibilityUIElement::uiElementArrayAttributeValue(JSStringRef, Vector<AccessibilityUIElement>&) const { }
void AccessibilityUIElement::columnHeaders(Vector<AccessibilityUIElement>&) const { }
void AccessibilityUIElement::rowHeaders(Vector<AccessibilityUIElement>&) const { }
#endif

[David Farler]

It did but I must be behind that change, I don't have those lines in r163079. If those were added after that, then disregard and I'll update :)

[chris fleizach]

Comment on attachment 222681 [details]
patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 222681 [details]
patch

Clearing flags on attachment: 222681

Committed r163117: <http://trac.webkit.org/changeset/163117>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.