Bug 127900 – Web Inspector: Show profile data in the discrete Scripts timeline view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Start showing profile data in the DataGrid of the ScriptTimelineView.

[Radar WebKit Bug Importer]

<rdar://problem/15944978>

[Timothy Hatcher]

Created attachment 222653 [details]
Patch

[Timothy Hatcher]

Created attachment 222654 [details]
Screenshot

[Joseph Pecoraro]

Comment on attachment 222653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222653&action=review

r=me

> Source/WebInspectorUI/ChangeLog:3
> +        Show profile data in the desecrate Scripts timeline view.

Typo: "desecrate"

> Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js:543
> +            // Keep all the elements at the same depth once the maximum is reached.
> +            childrenSubstring += i === maximumSidebarTreeDepth ? " .children" : " > .children";
> +            styleText += "." + WebInspector.NavigationSidebarPanel.ContentTreeOutlineElementStyleClassName + childrenSubstring + " > .item { ";

This must be some kind of a record for longest selector.

> Source/WebInspectorUI/UserInterface/ProfileNodeDataGridNode.js:35
> +    this._rangeEndTime = rangeEndTime || Infinity;

"0 || 0" is harmless, but  "0 || Infinity" could lead to a crazy accident. Maybe we should be a bit safer here?

> Source/WebInspectorUI/UserInterface/ScriptTimelineDataGridNode.js:33
> +    this._rangeEndTime = rangeEndTime || Infinity;

Ditto, 0 || Infinity.

> Source/WebInspectorUI/UserInterface/ScriptTimelineView.js:119
> +                dataGridNode = dataGridNode.traverseNextNode(false, null, true);

Gosh, these traverse functions need a better name to read at call sites. Same with that reveal function with a bunch of bools.

> Source/WebInspectorUI/UserInterface/TimelineDataGrid.js:274
> +        // Collect parent nodes htat need their children sorted. So this in two phases since

Typo: "htat"

[Timothy Hatcher]

https://trac.webkit.org/r163142