Bug 127896 – Web Inspector: Implement open/close Console window shortcut

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Diego Pino]

Console toolbar button tooltip (Option + Command + C) doesn't work. How to reproduce:

   * Open the Web Inspector.
   * Press Option + Command + C.

Expected result: The console window opens up (or closes if it was opened).
Actual result: The console window doesn't open.

The problem is that the shortcut tooltip is shown but its operation is not implemented.

[Radar WebKit Bug Importer]

<rdar://problem/15944643>

[Diego Pino]

Created attachment 222641 [details]
Patch

[Timothy Hatcher]

Comment on attachment 222641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review

> Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183
> +            result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387";

Arn't these the same symbol?

[Timothy Hatcher]

Comment on attachment 222641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review

>> Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183
>> +            result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387";
> 
> Arn't these the same symbol?

I guess on Mac they might be, but not on other platforms.

[Diego Pino]

Comment on attachment 222641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review

>>> Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183
>>> +            result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387";
>> 
>> Arn't these the same symbol?
> 
> I guess on Mac they might be, but not on other platforms.

\u2325 is the 'Option' key symbol (http://en.wikipedia.org/wiki/Option_key)
\u2387 is the 'Alternative' key symbol (http://en.wikipedia.org/wiki/Alt_key)

In Mac the 'Option' key (which is also labeled as 'Alt' I think) has always the '\u2325' symbol printed on the key. In no mac keyboards, the equivalent of the 'Option' key is the 'Alt' key, and although it has no symbol printed on it I think it's better to print the correspondent Unicode symbol for the 'Alt' key. As a matter of fact, the first time I checked the shortcuts I could understand the symbols for Shift and Control, but as for the Option or Command key (Mac key) symbols I had to figure out what keys were those.

[WebKit Commit Bot]

Comment on attachment 222641 [details]
Patch

Clearing flags on attachment: 222641

Committed r163086: <http://trac.webkit.org/changeset/163086>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.