Bug 127891 – WebKit2 View Gestures (Swipe): Provide a way for clients to provide views to swipe

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

Sometimes, clients want to swipe to or from a custom view hierarchy. Let's provide SPI to make this work (later we can think about the right way to do this, probably involving WebKit instantiating and owning the views on navigation to a particular scheme, or some such).

Implementation caveats: views must be layer backed and a contiguous, opaque rectangle.

<rdar://problem/15931413>

[Tim Horton]

Created attachment 222639 [details]
patch

[Tim Horton]

Comment on attachment 222639 [details]
patch

I have some significant revisions to make, de-r?ing for now.

[Tim Horton]

Created attachment 222647 [details]
ever so slightly more crazy

[Anders Carlsson]

Comment on attachment 222647 [details]
ever so slightly more crazy

View in context: https://bugs.webkit.org/attachment.cgi?id=222647&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:61
> +    void setCustomSwipeViews(Vector<RetainPtr<NSView>> views) { m_customSwipeViews = views; }

std::move(views).

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:62
> +    Vector<RetainPtr<NSView>> customSwipeViews() const { return m_customSwipeViews; }

You don't want to return this by reference?

[Tim Horton]

http://trac.webkit.org/changeset/163093