Bug 127885 - Web Inspector: Play Breakpoint Sound in Frontend
Summary: Web Inspector: Play Breakpoint Sound in Frontend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
: 126906 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-29 19:48 PST by Joseph Pecoraro
Modified: 2014-02-27 08:47 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (16.53 KB, patch)
2014-01-29 20:02 PST, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-29 19:48:12 PST 
This was refactored as part of the move of ScriptDebugServer/InspectorDebuggerAgent into JavaScriptCore. Make it work again!
Comment 1 Radar WebKit Bug Importer 2014-01-29 19:48:26 PST 
<rdar://problem/15943579>
Comment 2 Joseph Pecoraro 2014-01-29 20:02:05 PST 
Created attachment 222622 [details]
[PATCH] Proposed Fix

Please suggest a better name than "breakpointSound". I don't like it =(.
Comment 3 Timothy Hatcher 2014-01-29 20:26:05 PST 
Comment on attachment 222622 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222622&action=review

> Source/JavaScriptCore/inspector/ScriptDebugListener.h:76
> +    virtual void breakpointActionSound(int breakpointActionIdentifier) = 0;

Can we use unsigned? I hate int for things that don't need to be negative. Positive positive positive!

> Source/JavaScriptCore/inspector/protocol/Debugger.json:304
> +            "name": "breakpointSound",

playBreakpointSound? Any verb would help here.
Comment 4 Timothy Hatcher 2014-01-29 20:51:25 PST 
playBreakpointActionSound even.
Comment 5 Joseph Pecoraro 2014-01-30 10:29:04 PST 
Landed <http://trac.webkit.org/changeset/163071>.
Comment 6 Timothy Hatcher 2014-02-27 08:47:41 PST 
*** Bug 126906 has been marked as a duplicate of this bug. ***