RESOLVED FIXED 127885
Web Inspector: Play Breakpoint Sound in Frontend 
https://bugs.webkit.org/show_bug.cgi?id=127885
Summary Web Inspector: Play Breakpoint Sound in Frontend
Joseph Pecoraro
Reported 2014-01-29 19:48:12 PST
This was refactored as part of the move of ScriptDebugServer/InspectorDebuggerAgent into JavaScriptCore. Make it work again!
Attachments
[PATCH] Proposed Fix (16.53 KB, patch)
2014-01-29 20:02 PST, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-29 19:48:26 PST
<rdar://problem/15943579>
Joseph Pecoraro
Comment 2 2014-01-29 20:02:05 PST
Created attachment 222622 [details] [PATCH] Proposed Fix Please suggest a better name than "breakpointSound". I don't like it =(.
Timothy Hatcher
Comment 3 2014-01-29 20:26:05 PST
Comment on attachment 222622 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222622&action=review > Source/JavaScriptCore/inspector/ScriptDebugListener.h:76 > + virtual void breakpointActionSound(int breakpointActionIdentifier) = 0; Can we use unsigned? I hate int for things that don't need to be negative. Positive positive positive! > Source/JavaScriptCore/inspector/protocol/Debugger.json:304 > + "name": "breakpointSound", playBreakpointSound? Any verb would help here.
Timothy Hatcher
Comment 4 2014-01-29 20:51:25 PST
playBreakpointActionSound even.
Joseph Pecoraro
Comment 5 2014-01-30 10:29:04 PST
Landed <http://trac.webkit.org/changeset/163071>.
Timothy Hatcher
Comment 6 2014-02-27 08:47:41 PST
*** Bug 126906 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.