RESOLVED FIXED 127874
Remove display:run-in support 
https://bugs.webkit.org/show_bug.cgi?id=127874
Summary Remove display:run-in support
Andreas Kling
Reported 2014-01-29 17:17:00 PST
The "run-in" display type is disproportionately complex for such a rare use-case. Blink recently nuked it from their fork, and Gecko never implemented in the first place. <rdar://problem/15926949>
Attachments
Patch (125.90 KB, patch)
2014-01-29 17:39 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (125.90 KB, patch)
2014-01-29 18:58 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (278.69 KB, patch)
2014-01-29 19:03 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (314.70 KB, patch)
2014-02-05 15:23 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch again.. (314.68 KB, patch)
2014-02-05 15:51 PST, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (534.75 KB, application/zip)
2014-02-05 18:55 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (628.33 KB, application/zip)
2014-02-05 19:38 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (1012.30 KB, application/zip)
2014-02-05 20:09 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (652.71 KB, application/zip)
2014-02-05 20:25 PST, Build Bot 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-01-29 17:39:45 PST
Created attachment 222612 [details] Patch
Andreas Kling
Comment 2 2014-01-29 18:58:52 PST
Created attachment 222620 [details] Patch
Andreas Kling
Comment 3 2014-01-29 19:03:46 PST
Created attachment 222621 [details] Patch
Andreas Kling
Comment 4 2014-02-05 15:23:23 PST
Created attachment 223270 [details] Patch
Andreas Kling
Comment 5 2014-02-05 15:51:45 PST
Created attachment 223276 [details] Patch again..
Build Bot
Comment 6 2014-02-05 18:55:45 PST
Comment on attachment 223276 [details] Patch again.. Attachment 223276 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6296538758250496 New failing tests: fast/forms/form-hides-table.html
Build Bot
Comment 7 2014-02-05 18:55:47 PST
Created attachment 223289 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-02-05 19:38:00 PST
Comment on attachment 223276 [details] Patch again.. Attachment 223276 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4839521703165952 New failing tests: fast/forms/form-hides-table.html
Build Bot
Comment 9 2014-02-05 19:38:03 PST
Created attachment 223292 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 10 2014-02-05 20:09:06 PST
Comment on attachment 223276 [details] Patch again.. Attachment 223276 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6235005969760256 New failing tests: fast/forms/form-hides-table.html
Build Bot
Comment 11 2014-02-05 20:09:08 PST
Created attachment 223294 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 12 2014-02-05 20:25:22 PST
Comment on attachment 223276 [details] Patch again.. Attachment 223276 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5130769206870016 New failing tests: fast/forms/form-hides-table.html
Build Bot
Comment 13 2014-02-05 20:25:24 PST
Created attachment 223296 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 14 2014-02-06 09:46:14 PST
Comment on attachment 223276 [details] Patch again.. View in context: https://bugs.webkit.org/attachment.cgi?id=223276&action=review > Source/WebCore/rendering/RenderInline.cpp:-131 > - setInline(true); // Needed for run-ins, since run-in is considered a block display type. maybe assert isInline() here
Andreas Kling
Comment 15 2014-02-06 13:19:23 PST
Committed r163560: <http://trac.webkit.org/changeset/163560>
Daniel Bates
Comment 16 2014-02-12 13:46:51 PST
(In reply to comment #15) > Committed r163560: <http://trac.webkit.org/changeset/163560> This caused us to regress handling of SVG <tspan> and <textPath>. See bug #128552 for more details.
Drew Yao
Comment 17 2014-08-01 10:46:31 PDT
*** Bug 116475 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.