Bug 127852 - [CSS Shapes] Rounded Insets Let Content Overlap Shape
Summary: [CSS Shapes] Rounded Insets Let Content Overlap Shape
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords: InRadar
Depends on:
Blocks: 124173
  Show dependency tree / graph
 
Reported: 2014-01-29 13:13 PST by Bear Travis
Modified: 2014-02-06 17:16 PST (History)
11 users (show)

See Also:

Attachments
Test case (1.36 KB, text/html)
2014-01-29 13:13 PST, Bear Travis 		no flags Details
Patch (8.04 KB, patch)
2014-02-06 11:21 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Patch (8.03 KB, patch)
2014-02-06 11:22 PST, Zoltan Horvath 		bjonesbe: review+
Details | Formatted Diff | Diff
Patch for landing (8.05 KB, patch)
2014-02-06 16:38 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2014-01-29 13:13:57 PST 
Created attachment 222591 [details]
Test case

In some cases, inline content overlaps with insets with a round applied.

Appears to depend on the size of the float shape.
Comment 1 Radar WebKit Bug Importer 2014-01-31 11:04:59 PST 
<rdar://problem/15958574>
Comment 2 Zoltan Horvath 2014-02-06 11:21:26 PST 
Created attachment 223352 [details]
Patch
Comment 3 Zoltan Horvath 2014-02-06 11:22:27 PST 
Created attachment 223354 [details]
Patch
Comment 4 Bem Jones-Bey 2014-02-06 15:46:57 PST 
Comment on attachment 223354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223354&action=review

> Source/WebCore/css/LengthFunctions.h:41
> +FloatSize floatSizeForLengthSize(const LengthSize&, float maxWidth, float maxHeight);

I think it's ok as is, but I could see an argument for using a const FloatSize& instead of two floats. I'll leave that call up to you, since I'm not sure if it's better or not.
Comment 5 Zoltan Horvath 2014-02-06 16:38:46 PST 
Created attachment 223405 [details]
Patch for landing

I'm landing it with LayoutSize.
Comment 6 Zoltan Horvath 2014-02-06 16:39:26 PST 
I meant FloatSize.
Comment 7 WebKit Commit Bot 2014-02-06 17:16:14 PST 
Comment on attachment 223405 [details]
Patch for landing

Clearing flags on attachment: 223405

Committed r163585: <http://trac.webkit.org/changeset/163585>
Comment 8 WebKit Commit Bot 2014-02-06 17:16:18 PST 
All reviewed patches have been landed.  Closing bug.