"JSC will now always support the debugger. Hence, the #if ENABLE(JAVASCRIPT_DEBUGGER) checks can be removed." http://trac.webkit.org/r162970 - https://bugs.webkit.org/show_bug.cgi?id=127805 Let's remove all guards.
Created attachment 222576 [details] Patch
Comment on attachment 222576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222576&action=review r=me with the one issue addressed. > Source/WebCore/inspector/InspectorInstrumentation.cpp:-1132 > - Please revert the removal of this empty line.
Committed r163024: <http://trac.webkit.org/changeset/163024>
(In reply to comment #2) > Please revert the removal of this empty line. Thanks for noticing this typo, I removed it before landing.
Hehe, I just wrote up a patch that did this yesterday and was going to send it out today. Thanks for taking care of this!
Comment on attachment 222576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222576&action=review What about: Source/autotools/SetupWebKitFeatures.m4 WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props WebKitLibraries/win/tools/vsprops/FeatureDefines.props Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig Source/WebCore/Configurations/FeatureDefines.xcconfig Source/WebKit/mac/Configurations/FeatureDefines.xcconfig Source/WebKit2/Configurations/FeatureDefines.xcconfig > Source/WebCore/bindings/js/JSDOMWindowBase.cpp:109 > -#if !ENABLE(JAVASCRIPT_DEBUGGER) || !ENABLE(INSPECTOR) > +#if !ENABLE(INSPECTOR) > UNUSED_PARAM(object); > return false; > #else Down below there is a nested ENABLE(INSPECTOR) which can be removed because it is now inside of an ENABLE(INSPECTOR). > Tools/Scripts/webkitperl/FeatureList.pm:-316 > - { option => "javascript-debugger", desc => "Toggle JavaScript Debugger support", > - define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javascriptDebuggerSupport }, What about the definition of $javascriptDebuggerSupport?
(In reply to comment #5) > Hehe, I just wrote up a patch that did this yesterday and was going to send it out today. Thanks for taking care of this! I checked the bugzilla and haven't found bug report about it. (In reply to comment #6) > (From update of attachment 222576 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222576&action=review > > What about: > Source/autotools/SetupWebKitFeatures.m4 > WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props > WebKitLibraries/win/tools/vsprops/FeatureDefines.props > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig > Source/WebCore/Configurations/FeatureDefines.xcconfig > Source/WebKit/mac/Configurations/FeatureDefines.xcconfig > Source/WebKit2/Configurations/FeatureDefines.xcconfig >... Good point, let me run one more round.
(In reply to comment #7) > (In reply to comment #5) > > Hehe, I just wrote up a patch that did this yesterday and was going to send it out today. Thanks for taking care of this! > > I checked the bugzilla and haven't found bug report about it. I didn't create a bug for it. I just posted that comment saying we should remove it, and started on a patch locally. Triggered a build and had to leave early. =) Not a problem, it puts me in a good place to review this patch.
Here is the new bug, I hope the last one for this task :) https://bugs.webkit.org/show_bug.cgi?id=127845