Bug 127824 - WKRemoteObjectCoder should support more argument types
Summary: WKRemoteObjectCoder should support more argument types
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-01-28 20:07 PST by Ian Henderson
Modified: 2014-01-28 21:09 PST (History)
2 users (show)

See Also:

proposed patch (1.27 KB, patch)
2014-01-28 20:09 PST, Ian Henderson
andersca: review+
ian: commit-queue-
Details | Formatted Diff | Diff
revised patch (1.86 KB, patch)
2014-01-28 20:31 PST, Ian Henderson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Henderson 2014-01-28 20:07:29 PST
BOOL becomes char on some platforms, so we need to support at least 'c'.
Comment 1 Ian Henderson 2014-01-28 20:09:32 PST
Created attachment 222548 [details]
proposed patch
Comment 2 Anders Carlsson 2014-01-28 20:24:54 PST
Comment on attachment 222548 [details]
proposed patch

What about decoding?
Comment 3 Ian Henderson 2014-01-28 20:31:33 PST
Created attachment 222551 [details]
revised patch
Comment 4 Ian Henderson 2014-01-28 20:32:55 PST
It's strange that things seemed to work without throwing exceptions.  I updated the decoding method too.
Comment 5 WebKit Commit Bot 2014-01-28 21:09:33 PST
Comment on attachment 222551 [details]
revised patch

Clearing flags on attachment: 222551

Committed r163000: <http://trac.webkit.org/changeset/163000>
Comment 6 WebKit Commit Bot 2014-01-28 21:09:34 PST
All reviewed patches have been landed.  Closing bug.