Bug 127809 - REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out
Summary: REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/fl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2014-01-28 15:37 PST by Alexey Proskuryakov
Modified: 2014-01-29 08:07 PST (History)
6 users (show)

See Also:

Attachments
patch (6.01 KB, patch)
2014-01-29 07:40 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (3.92 KB, patch)
2014-01-29 07:43 PST, Antti Koivisto 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-28 15:37:41 PST 
css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html fail with a timeout on debug bots every time after <http://trac.webkit.org/r162947>.

This is also reproducible locally.
Comment 1 Alexey Proskuryakov 2014-01-28 15:44:45 PST 
Skipped in <http://trac.webkit.org/r162974>. Antti is going to investigate tomorrow.
Comment 2 Antti Koivisto 2014-01-29 07:40:41 PST 
Created attachment 222571 [details]
patch
Comment 3 Antti Koivisto 2014-01-29 07:43:04 PST 
Created attachment 222572 [details]
another
Comment 4 Anders Carlsson 2014-01-29 07:55:41 PST 
Comment on attachment 222572 [details]
another

View in context: https://bugs.webkit.org/attachment.cgi?id=222572&action=review

I don't like the "gridSize()" concept, but I can't really think of something better...

> Source/WebCore/rendering/RenderView.cpp:640
> +    static const unsigned maximumRepaintRegionGridSize = 16 * 16;
> +    if (m_accumulatedRepaintRegion->gridSize() > maximumRepaintRegionGridSize)
> +        m_accumulatedRepaintRegion = std::make_unique<Region>(m_accumulatedRepaintRegion->bounds());

I think this could use a comment.
Comment 5 Antti Koivisto 2014-01-29 08:07:36 PST 
https://trac.webkit.org/r163019