Bug 127807 - Heap::writeBarrier shouldn't be static
Summary: Heap::writeBarrier shouldn't be static
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 128324
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-28 15:19 PST by Mark Hahnenberg
Modified: 2014-02-06 16:37 PST (History)
1 user (show)

See Also:

Attachments
Patch (21.02 KB, patch)
2014-01-28 15:25 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (20.63 KB, patch)
2014-01-28 15:27 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (18.92 KB, patch)
2014-02-05 21:06 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (21.68 KB, patch)
2014-02-05 21:56 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (19.04 KB, patch)
2014-02-06 15:15 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (21.75 KB, patch)
2014-02-06 15:16 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-01-28 15:19:14 PST 
Currently it looks up the Heap in which to fire the write barrier by using the cell passed to it. Pretty much every call site already has a reference to the VM or the Heap itself. It seems wasteful to look it up all over again.
Comment 1 Mark Hahnenberg 2014-01-28 15:25:46 PST 
Created attachment 222507 [details]
Patch
Comment 2 Mark Hahnenberg 2014-01-28 15:27:31 PST 
Created attachment 222508 [details]
Patch
Comment 3 Geoffrey Garen 2014-01-28 22:03:39 PST 
Comment on attachment 222508 [details]
Patch

r=me if you fix the build
Comment 4 Mark Hahnenberg 2014-02-05 21:06:04 PST 
Created attachment 223302 [details]
Patch
Comment 5 Mark Hahnenberg 2014-02-05 21:06:18 PST 
(In reply to comment #4)
> Created an attachment (id=223302) [details]
> Patch

EWS fodder.
Comment 6 Mark Hahnenberg 2014-02-05 21:56:10 PST 
Created attachment 223306 [details]
Patch
Comment 7 Mark Hahnenberg 2014-02-06 09:54:31 PST 
Committed r163542: <http://trac.webkit.org/changeset/163542>
Comment 8 WebKit Commit Bot 2014-02-06 12:15:42 PST 
Re-opened since this is blocked by bug 128324
Comment 9 Mark Hahnenberg 2014-02-06 15:15:00 PST 
Created attachment 223388 [details]
Patch
Comment 10 Mark Hahnenberg 2014-02-06 15:16:15 PST 
Created attachment 223390 [details]
Patch
Comment 11 Geoffrey Garen 2014-02-06 15:24:58 PST 
Comment on attachment 223390 [details]
Patch

r=me
Comment 12 WebKit Commit Bot 2014-02-06 16:37:31 PST 
Comment on attachment 223390 [details]
Patch

Clearing flags on attachment: 223390

Committed r163576: <http://trac.webkit.org/changeset/163576>
Comment 13 WebKit Commit Bot 2014-02-06 16:37:34 PST 
All reviewed patches have been landed.  Closing bug.