RESOLVED FIXED 127807
Heap::writeBarrier shouldn't be static 
https://bugs.webkit.org/show_bug.cgi?id=127807
Summary Heap::writeBarrier shouldn't be static
Mark Hahnenberg
Reported 2014-01-28 15:19:14 PST
Currently it looks up the Heap in which to fire the write barrier by using the cell passed to it. Pretty much every call site already has a reference to the VM or the Heap itself. It seems wasteful to look it up all over again.
Attachments
Patch (21.02 KB, patch)
2014-01-28 15:25 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (20.63 KB, patch)
2014-01-28 15:27 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (18.92 KB, patch)
2014-02-05 21:06 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (21.68 KB, patch)
2014-02-05 21:56 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (19.04 KB, patch)
2014-02-06 15:15 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (21.75 KB, patch)
2014-02-06 15:16 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-01-28 15:25:46 PST
Created attachment 222507 [details] Patch
Mark Hahnenberg
Comment 2 2014-01-28 15:27:31 PST
Created attachment 222508 [details] Patch
Geoffrey Garen
Comment 3 2014-01-28 22:03:39 PST
Comment on attachment 222508 [details] Patch r=me if you fix the build
Mark Hahnenberg
Comment 4 2014-02-05 21:06:04 PST
Created attachment 223302 [details] Patch
Mark Hahnenberg
Comment 5 2014-02-05 21:06:18 PST
(In reply to comment #4) > Created an attachment (id=223302) [details] > Patch EWS fodder.
Mark Hahnenberg
Comment 6 2014-02-05 21:56:10 PST
Created attachment 223306 [details] Patch
Mark Hahnenberg
Comment 7 2014-02-06 09:54:31 PST
Committed r163542: <http://trac.webkit.org/changeset/163542>
WebKit Commit Bot
Comment 8 2014-02-06 12:15:42 PST
Re-opened since this is blocked by bug 128324
Mark Hahnenberg
Comment 9 2014-02-06 15:15:00 PST
Created attachment 223388 [details] Patch
Mark Hahnenberg
Comment 10 2014-02-06 15:16:15 PST
Created attachment 223390 [details] Patch
Geoffrey Garen
Comment 11 2014-02-06 15:24:58 PST
Comment on attachment 223390 [details] Patch r=me
WebKit Commit Bot
Comment 12 2014-02-06 16:37:31 PST
Comment on attachment 223390 [details] Patch Clearing flags on attachment: 223390 Committed r163576: <http://trac.webkit.org/changeset/163576>
WebKit Commit Bot
Comment 13 2014-02-06 16:37:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.